[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 17 07:49:21 PST 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D42168#978593, @ABataev wrote:

> After some investigation, I think this whole code is incorrect. We should not rely on the fact that there is no padding on some architectures and should mix the type generated by the Clang and initial value, generated by LLVM.


I'm not sure I understand what you mean. Do you refer to `auto Align = CharUnits::fromQuantity(1)`?


Repository:
  rC Clang

https://reviews.llvm.org/D42168





More information about the cfe-commits mailing list