[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, ioeric, hokein.
Herald added a subscriber: klimek.

We will return errors for non-added files for now.
Another alternative for clangd would be to read non-added files from
disk and provide useful features anyway.

There are still some cases that fail with assertion (e.g., code
complete). We should address those too, but they require more subtle
changes to the code and therefore out of scope of this patch.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42164

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  test/clangd/crash.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42164.130119.patch
Type: text/x-patch
Size: 8933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180117/c40f02df/attachment.bin>