[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

[Aleksei Sidorin via Phabricator via cfe-commits]

a.sidorin added a comment.

Hello Adam. I have a nit inline.



================
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1256
+    if (Cond(Reg.second)) {
+      State = setIteratorPosition(State, Reg.first, Proc(Reg.second));
+    }
----------------
Updating ProgramState is usually considered as an expensive operation. Instead, we can update maps (RegionMap and SymbolMap) and then, if they have any updates, create a state containing these maps. What do you think?


https://reviews.llvm.org/D32747