[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.h:15
+#include "clang/Lex/Preprocessor.h"
+
+namespace clang {
----------------
Please include <string>.


================
Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:8
+constructs exist for the task.
+The relevant sections in the C++ Coreguidelines are 
+`Enum.1 <https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#enum1-prefer-enumerations-over-macros>`_,
----------------
Will be good idea to separate statements with empty line.


================
Comment at: test/clang-tidy/cppcoreguidelines-macro-usage-custom.cpp:17
+
+
+#define DEBUG_CONSTANT 0
----------------
Unnecessary empty line.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41648