D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

Szabolcs Nagy via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 15 04:33:03 PST 2018


On 13/01/18 12:33, Blower, Melanie wrote:
>> -----Original Message-----
>> From: Szabolcs Nagy via Phabricator [mailto:reviews at reviews.llvm.org]
>> Sent: Friday, January 12, 2018 3:18 PM 
>>
>> nsz added a comment.
>>  
>>
>> it is not clear to me from the original bug report what "fedora 27 workloads"
>> break because of the lack of _Float128 type on x86.  The glibc headers refer to
>> _Float128, but normal include should not break unless the compiler claims to be
>>> =gcc-7 or somebody explicitly requested the _Float128 support.
> [Blower, Melanie] I was building open source projects like ffmpeg, linux from scratch, and others. I was incorrect in my original post, I was using a patched compiler which led to _Float128 being exposed. In an unpatched clang this problem doesn't arise.  I regret the lack of care taken in my analysis of the problem.

then please revert the related patches.
(or finish the _Float128 support).



More information about the cfe-commits mailing list