[PATCH] D42077: Ensure code complete with !LoadExternal sees all local decls.

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.

noload_lookups() was too lazy: in addition to avoiding external decls, it
avoided populating the lazy lookup structure for internal decls.
This is the right behavior for the existing callsite in ASTDumper, but I think
it's not a very useful default, so we populate it by default.

While here:

- remove an unused test file accidentally added in r322371.
- remove lookups_begin()/lookups_end() in favor of lookups().begin(), which is more common and more efficient.


Repository:
  rC Clang

https://reviews.llvm.org/D42077

Files:
  include/clang/AST/DeclBase.h
  include/clang/AST/DeclLookups.h
  lib/AST/ASTDumper.cpp
  lib/AST/DeclBase.cpp
  test/Index/complete-pch-skip.cpp
  test/Index/complete-pch-skip.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42077.129875.patch
Type: text/x-patch
Size: 5717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180115/4cd42fcd/attachment-0001.bin>