[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

Benjamin Kramer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 15 08:47:57 PST 2018


bkramer added a comment.

We should have a unit test for this, otherwise it's dead code.



================
Comment at: include/clang/Sema/Lookup.h:791
+  /// \param Ctx the context which Sema begins to visit.
+  virtual void BeginVisitContext(DeclContext *Ctx) {};
 };
----------------
ilya-biryukov wrote:
> Maybe rename it to `VisitedContext` ? Seems more in-line with `FoundDecl`.
> `BeginVisitContext` also suggest there should be `EndVisitContext`
Semicolon is not needed here.


Repository:
  rC Clang

https://reviews.llvm.org/D42071





More information about the cfe-commits mailing list