[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 13 08:39:37 PST 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D41976#975659, @tvanslyke wrote:

> Here are the results:
>
>   Comparing old-copymove.json to new-copymove.json
>   Benchmark                        Time             CPU      Time Old      Time New       CPU Old       CPU New
>   -------------------------------------------------------------------------------------------------------------
>   BM_string_move_SSO            -0.5833         -0.5833            12             5            12             5
>   BM_string_copy_SSO            +0.0000         +0.0000            23            23            23            23
>   BM_string_move_no_SSO         -0.6250         -0.6250             8             3             8             3
>   BM_string_copy_no_SSO         +0.0000         +0.0000            11            11            11            11
>   BM_string_stable_sort         -0.0779         -0.0779       2772114       2556118       2772031       2556036
>   
>
> I put the benchmark on pastebin because it's a tad too long to paste here IMO:  https://pastebin.com/mk1JXQme


Perhaps it should be added to the already-existing `benchmarks/string.bench.cpp`?
Not sure whether those are being used in test-suite/LNT.


https://reviews.llvm.org/D41976





More information about the cfe-commits mailing list