[PATCH] D41996: [clangd] Code completion uses Sema for NS-level things in the current file.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In https://reviews.llvm.org/D41996#974751, @hokein wrote:

> nice, LGTM.
>
> By `r322377`, I think you mean `r322371`.


Done.

> We also need to set `CollectorOpts.IndexMainFiles` to `false` in  `FileIndex.cpp::indexAST` -- we don't need dynamic index to catch the symbols in current main file since sema does that for us now :)

This would fix the problem. But it will break index-based go-to-definition for modified files, so I'd rather leave this at least for now, and pursue deduplicating symbols instead.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41996