[PATCH] D41989: [CodeComplete] Add an option to omit results from the preamble.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 12 06:34:22 PST 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM modulo the comment about variable name.



================
Comment at: lib/Sema/SemaLookup.cpp:3502
+                               bool IncludeDependentBases,
+                               bool Load) {
   if (!Ctx)
----------------
Maybe rename the variable to `LoadExternal`?
The intention of `Load` is not immediately clear. Also a bit longer name seems to be more in-line with the other code in this file.


Repository:
  rC Clang

https://reviews.llvm.org/D41989





More information about the cfe-commits mailing list