[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

Ekaterina Vaartis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 11 20:31:07 PST 2018


TyanNN added inline comments.


================
Comment at: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.remove_all/remove_all.pass.cpp:86
+
+        TEST_CHECK(fs::remove_all(p) == 0);
+        TEST_CHECK(!ec);
----------------
EricWF wrote:
> This test is incorrect. `ec` isn't passed to the function.
Indeed it isn't. I will fix it later today and commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D41830





More information about the cfe-commits mailing list