[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 11 15:30:02 PST 2018
EricWF marked 3 inline comments as done.
EricWF added a comment.
@rsmith The trait is already documented in `LanguageExtensions.rst`, so I'll assumed you missed that and are not trying to suggest more documentation is needed.
================
Comment at: include/clang/Basic/TypeTraits.h:91
+/// \brief Names for the array type traits.
+enum ArrayTypeTrait { ATT_ArrayRank, ATT_ArrayExtent };
----------------
rsmith wrote:
> Looks like you reformatted (and reindented) this whole file. If you meant to do that, please commit it as a separate change.
Woops!
================
Comment at: lib/Parse/ParseDeclCXX.cpp:1410
+ Tok.isOneOf(
+ tok::kw___is_abstract, tok::kw___is_aggregate,
+ tok::kw___is_arithmetic, tok::kw___is_array, tok::kw___is_assignable,
----------------
Woops, Clang-format seems to chewed this up.
https://reviews.llvm.org/D29930
More information about the cfe-commits
mailing list