[PATCH] D40677: [libcxx] Make std::basic_istream::get 0-terminate input array in case of error.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai marked an inline comment as done.
vsapsai added a comment.

Thanks for the review.



================
Comment at: libcxx/include/istream:970
         }
+        if (__n > 0)
+        {
----------------
mclow.lists wrote:
> I'm not a big fan of "putting braces around single statement blocks", and (see line 963) that doesn't match the rest of libcxx.
> 
Thanks for pointing this out. I was making sure to follow the style of opening curly brace on its own line and missed that you don't need curly braces in this case.


================
Comment at: libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_pointer_size_chart.pass.cpp:16
+// XFAIL: with_system_cxx_lib=macosx10.8
+// XFAIL: with_system_cxx_lib=macosx10.7
+
----------------
mclow.lists wrote:
> mclow.lists wrote:
> > Does this need to XFAIL for clang < 6 as well?
> > 
> I don't think that it does.  Never mind this.
In theory, it should be done for earlier versions too. But in practice that's not required.


https://reviews.llvm.org/D40677