[PATCH] D41800: [analyzer] Use a custom program point for the check::NewAllocator callback.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 11 09:30:01 PST 2018


NoQ added inline comments.


================
Comment at: test/Analysis/NewDelete-path-notes.cpp:44
 // CHECK-NEXT:           <dict>
-// CHECK-NEXT:            <key>line</key><integer>6</integer>
+// CHECK-NEXT:            <key>line</key><integer>7</integer>
 // CHECK-NEXT:            <key>col</key><integer>3</integer>
----------------
a.sidorin wrote:
> Not even a minor concern for this patch, but I think that placing `//RUN` and `//CHECK` after the code being tested could save us from massive changes of line numbers.
Hmm, not sure if i understand, you mean //before// the code? (it would save us from line number changes in plists, but it'd make the tests harder to read because you'd have to scroll all the way down through the plist to find the actual code).


https://reviews.llvm.org/D41800





More information about the cfe-commits mailing list