[PATCH] D41941: [WebAssembly] Change int_fast16_t to 32-bit

Derek Schuff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 11 09:21:09 PST 2018


dschuff added inline comments.


================
Comment at: lib/Basic/Targets/WebAssembly.h:108
   IntType getLeastIntTypeByWidth(unsigned BitWidth, bool IsSigned) const final {
-    // WebAssembly uses long long for int_least64_t and int_fast64_t.
-    return BitWidth == 64
+    // WebAssembly uses long long for int_least64_t and int_fast64_t, and int
+    // for int_least16_t and int_fast16_t.
----------------
I think we want least16_t to still be short, no? We do still support 16-bit shorts, so my interpretation is that the smallest type with width of at least 16 should still be 16.


Repository:
  rC Clang

https://reviews.llvm.org/D41941





More information about the cfe-commits mailing list