[PATCH] D40677: [libcxx] Make std::basic_istream::get 0-terminate input array in case of error.

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

A couple of nits, but other than that, looks fine.



================
Comment at: libcxx/include/istream:970
         }
+        if (__n > 0)
+        {
----------------
I'm not a big fan of "putting braces around single statement blocks", and (see line 963) that doesn't match the rest of libcxx.



================
Comment at: libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_pointer_size_chart.pass.cpp:16
+// XFAIL: with_system_cxx_lib=macosx10.8
+// XFAIL: with_system_cxx_lib=macosx10.7
+
----------------
Does this need to XFAIL for clang < 6 as well?



https://reviews.llvm.org/D40677