[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 10 10:40:53 PST 2018


NoQ added a comment.

In https://reviews.llvm.org/D35109#969712, @baloghadamsoftware wrote:

> In https://reviews.llvm.org/D35109#969109, @NoQ wrote:
>
> > I guess it'd be an `-analyzer-config` flag. You can add it to the `AnalyzerOptions` object, which has access to these flags and can be accessed from `AnalysisManager`.
>
>
> OK, I can do that. BUt how should I call it? The name should be something the user also understands, not referring to some internal stuff. Any ideas?


I guess a lot of these options already refer to internal stuff. Similarly to off-by-default checkers, such option would not be for users to be thinking whether they want it or not, it is a flag to hide an experimental feature from users completely, while still being able to develop it incrementally, until it's ready to be enabled by default.

`-analyzer-config aggressive-relational-comparison-simplification=true` sounds good to me.


https://reviews.llvm.org/D35109





More information about the cfe-commits mailing list