[PATCH] D40478: Added control flow architecture protection Flag

[Oren Ben Simhon via Phabricator via cfe-commits]

oren_ben_simhon added inline comments.


================
Comment at: test/CodeGen/x86-cf-protection.c:1
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=branch %s 2>&1 | FileCheck %s --check-prefix=BRANCH
----------------
alexfh wrote:
> Any reason this test runs clang with "-S" and "-emit-llvm"? Neither of those seems to be needed for the actual checks being made below.
I agree that -emit-llvm is redundant for the test checks. Without -S  the command has no output on stdout or stderr. So the run fails and doesn't execute.


Repository:
  rC Clang

https://reviews.llvm.org/D40478