[PATCH] D41759: [clangd] Catch more symbols in SymbolCollector.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 8 05:29:37 PST 2018
hokein added inline comments.
================
Comment at: clangd/index/SymbolCollector.cpp:89
+ // violations.
+ if (ND->isInAnonymousNamespace())
return true;
----------------
ilya-biryukov wrote:
> Why don't we include symbols from anonymous namespaces too?
> They are very similar to static symbols.
Yeah, these symbols need a special handling (the qualified name is like `foo::<anonymous>::bar`), we don't support them well enough. I think it is fine to ignore them at the moment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41759
More information about the cfe-commits
mailing list