[PATCH] D41668: [clangd] Add static index for the global code completion.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 5 06:00:00 PST 2018
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clangd/CodeComplete.cpp:554
+ const SpecifiedScope &SSInfo,
+ llvm::StringRef IndexSource = "") {
CompletionItem Item;
----------------
Maybe `IndexSourceLabel`?
================
Comment at: clangd/CodeComplete.cpp:577
+
return Item;
----------------
Is this blank line intended?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41668
More information about the cfe-commits
mailing list