[PATCH] D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name

Miklos Vajna via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 00:17:49 PST 2018


vmiklos added a comment.

In https://reviews.llvm.org/D41716#967237, @lebedev.ri wrote:

> That changes the defaults though. I thought clang-tidy *tried* to produce the same results
>  on different clang-tidy versions with the same `.clang-tidy` config? Or is there no such guarantees?


Hmm, I see this as a trade-off between backwards compatibility and consistency. Here I went for consistency, so that all of readability-inconsistent-declaration-parameter-name, modernize-use-default-member-init and modernize-use-using default to IgnoreMacros=1. But I don't have a too strong opinion on that, can change the default to 0 if really wanted,


https://reviews.llvm.org/D41716





More information about the cfe-commits mailing list