[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

[Eric Christopher via Phabricator via cfe-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Couple of inline comments, otherwise I'm pretty happy. I'd wait for an ack by Richard for this though.

-eric



================
Comment at: lib/CodeGen/CGBuiltin.cpp:7673
 
-Value *CodeGenFunction::EmitX86CpuInit() {
+Value *CodeGenFunction::EmitX86CpuInit(CGBuilderTy &Builder) {
   llvm::FunctionType *FTy = llvm::FunctionType::get(VoidTy,
----------------
Why do you need to pass in a Builder?


================
Comment at: lib/CodeGen/CodeGenFunction.cpp:2324
+              llvm::Triple::x86_64) &&
+         "Only implemented for x86 targets");
+
----------------
Can you get here via trying to compile code for another cpu?


https://reviews.llvm.org/D40819