[PATCH] D41517: mmintrin.h documentation fixes and updates

[Katya Romanova via Phabricator via cfe-commits]

kromanova added inline comments.


================
Comment at: lib/Headers/mmintrin.h:1292
 ///
-/// This intrinsic corresponds to the <c> VXORPS / XORPS </c> instruction.
+/// This intrinsic corresponds to the <c> XOR </c> instruction.
 ///
----------------
craig.topper wrote:
> PXOR?
For which platform/compiler? 
 
I checked, for x86_64 Linux XORPS(no avx)/VXORPS (with -mavx) is generated.
For PS4 we generate XORL.

I guess, we need to write something more generic, implying that an appropriate platform-specific XOR instruction is generated. 


================
Comment at: lib/Headers/mmintrin.h:1384
 ///
-/// This intrinsic corresponds to the <c> VPSHUFD / PSHUFD </c> instruction.
+/// This intrinsic corresponds to the <c> PSHUFD </c> instruction.
 ///
----------------
craig.topper wrote:
> This is overly specific there is no guarantee we'd use those instructions. If it was a constant we'd probably just use a load.
That's right. I think we should use the following wording to match other _mm_set* intrinsics documentation in this file.

/// This intrinsic is a utility function and does not correspond to a specific
///    instruction.



https://reviews.llvm.org/D41517