[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

Daniel Neilson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 2 12:51:23 PST 2018


dneilson added a comment.

In https://reviews.llvm.org/D41677#966094, @rjmccall wrote:

> I'm glad to hear that progress is finally happening on this.
>
> The change to CGBuilder looks good to me.  I'm going to take your word for it that the test changes are all just obvious updates; if there's one in particular that you'd like me to look at, I'd be happy to.


Thanks! Yeah, the CGBuilder change is the meat of it. The test changes are all either sed-script changes, or manual fixes. For the manual fixes I made an effort to make sure that if the test wasn't checking for a specific alignment value before this change then it won't be checking for a specific alignment value after it either (i.e. matches like align {{[0-9]+}} when the alignment value doesn't matter).


Repository:
  rC Clang

https://reviews.llvm.org/D41677





More information about the cfe-commits mailing list