[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 1 05:07:24 PST 2018


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:13
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+using namespace clang::ast_matchers;
----------------
Please include cassert, Regex.h, raw_ostream.h, SmallString.h.


================
Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.h:14
+#include "../ClangTidy.h"
+
+namespace clang {
----------------
Please include string.


================
Comment at: docs/clang-tidy/checks/bugprone-unused-return-value.rst:17
+
+   - ``std::async``. Not using the return value makes the call synchronous.
+   - ``std::launder``. Not using the return value usually means that the
----------------
Please add round brackets to all functions/methods here and below.


https://reviews.llvm.org/D41655





More information about the cfe-commits mailing list