[PATCH] D41566: [Modules TS] Diagnose exported internal linkage declarations

Hamza Sood via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 28 11:17:10 PST 2017


hamzasood updated this revision to Diff 128302.
hamzasood added a comment.

I've removed the `isExported` fix for namespaces as it's somewhat unrelated to this patch.
I'll do a separate patch for fixing namespaces (which will include the stuff removed from here and a bit more)


https://reviews.llvm.org/D41566

Files:
  include/clang/AST/DeclBase.h
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaDecl.cpp
  test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp
  test/CXX/modules-ts/basic/basic.def.odr/p4/module.cppm
  test/CXX/modules-ts/basic/basic.def.odr/p4/user.cpp
  test/CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.interface/p2.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41566.128302.patch
Type: text/x-patch
Size: 9919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171228/481d8d60/attachment.bin>


More information about the cfe-commits mailing list