[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

[Boris Kolpackov via Phabricator via cfe-commits]

boris added a comment.

I don't think it will be wise for me to accept this revision since I can't claim to have good understanding of Clang's internal modules model. I think it will be wise to have Richard take a look.



================
Comment at: lib/Basic/Module.cpp:349
 
+  // Everything visible to the interface unit's global module fragment is
+  // visible to the interface unit.
----------------
This comment (not sure about the code)  sounds wrong to me: names from the interface unit before the module purview (I assume this is what "global module fragment" refers to) should not be visible in the implementation units.


https://reviews.llvm.org/D40443