[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

Dimitry Andric via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 24 08:45:14 PST 2017


dim added a comment.

Actually, having thought about it a little more, if the warning is "rather broken", or even "completely broken", depending on one's point of view, then maybe it is better not have it under `-Wextra` either?  E.g. somebody has to ask for the warning specifically, using `-Wtautological-constant-compare`, or use `-Weverything`?

I ask this, because in FreeBSD we have traditionally been using `-W`, which is (again, historically) an alias for `-Wextra`.  We now still have to explicitly use `-Wno-tautological-constant-compare` everywhere. :-(


Repository:
  rC Clang

https://reviews.llvm.org/D41512





More information about the cfe-commits mailing list