[PATCH] D41523: xmmintrin.h documentation fixes and updates

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 22 19:12:02 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Headers/xmmintrin.h:1706
 ///
-/// This intrinsic corresponds to the <c> VMOVSS / MOVSS + shuffling </c>
+/// This intrinsic corresponds to the <c> VBROADCASTSS / BROADCASTSS </c>
 ///    instruction.
----------------
There is no BROADCASTSS instruction. That's an AVX instruction that only exists as VBROADCASTSS. The orginal comment was correct for pre-AVX.


================
Comment at: lib/Headers/xmmintrin.h:2199
 ///
-/// This intrinsic corresponds to the <c> VPINSRW / PINSRW </c> instruction.
+/// This intrinsic corresponds to the <c> PINSRW </c> instruction.
 ///
----------------
Why is VPINSRW removed?


================
Comment at: lib/Headers/xmmintrin.h:2659
 ///
-/// This intrinsic corresponds to the <c> VMOVSS / MOVSS </c> instruction.
+/// This intrinsic corresponds to the <c> VBLENDPS / BLENDPS </c> instruction.
 ///
----------------
MOVSS is correct for pre SSE4.1 targets.


https://reviews.llvm.org/D41523





More information about the cfe-commits mailing list