[PATCH] D41517: mmintrin.h documentation fixes and updates

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 22 19:00:55 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Headers/mmintrin.h:88
 ///
-/// This intrinsic corresponds to the <c> VMOVQ / MOVD </c> instruction.
+/// This intrinsic corresponds to the <c> MOVD </c> instruction.
 ///
----------------
Shouldn't this be MOVQ?


================
Comment at: lib/Headers/mmintrin.h:104
 ///
-/// This intrinsic corresponds to the <c> VMOVQ / MOVD </c> instruction.
+/// This intrinsic corresponds to the <c> MOVD </c> instruction.
 ///
----------------
Shouldn't this be MOVQ?


================
Comment at: lib/Headers/mmintrin.h:1292
 ///
-/// This intrinsic corresponds to the <c> VXORPS / XORPS </c> instruction.
+/// This intrinsic corresponds to the <c> XOR </c> instruction.
 ///
----------------
PXOR?


================
Comment at: lib/Headers/mmintrin.h:1384
 ///
-/// This intrinsic corresponds to the <c> VPSHUFD / PSHUFD </c> instruction.
+/// This intrinsic corresponds to the <c> PSHUFD </c> instruction.
 ///
----------------
This is overly specific there is no guarantee we'd use those instructions. If it was a constant we'd probably just use a load.


================
Comment at: lib/Headers/mmintrin.h:1402
 ///
-/// This intrinsic corresponds to the <c> VPSHUFLW / PSHUFLW </c> instruction.
+/// This intrinsic corresponds to the <c> PSHUFLW </c> instruction.
 ///
----------------
This is overly specific


================
Comment at: lib/Headers/mmintrin.h:1419
 ///
-/// This intrinsic corresponds to the <c> VPUNPCKLBW + VPSHUFLW / PUNPCKLBW +
-///    PSHUFLW </c> instruction.
+/// This intrinsic corresponds to the <c> PUNPCKLBW + PSHUFLW </c> instruction.
 ///
----------------
This is overly specific


https://reviews.llvm.org/D41517





More information about the cfe-commits mailing list