[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 20 11:56:28 PST 2017


aaron.ballman added a comment.

You regenerate the HTML by running `clang/docs/tools/dump_ast_matchers.py`.



================
Comment at: unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1775
+  EXPECT_TRUE(notMatches("void func();", functionDecl(isNoReturn())));
+  EXPECT_TRUE(notMatches("void func() {};", functionDecl(isNoReturn())));
+
----------------
Spurious semicolon, which happens elsewhere in the tests as well -- please clean them all.


================
Comment at: unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1834
+                      functionDecl(isNoReturn())));
+}
+
----------------
For fun, I'd like to see a `matchesC` test for `_Noreturn` as well, just to be extra sure. :-)


Repository:
  rC Clang

https://reviews.llvm.org/D41455





More information about the cfe-commits mailing list