[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: include/__libunwind_config.h:46
+#  define _LIBUNWIND_CURSOR_SIZE 148
+#  define _LIBUNWIND_HIGHEST_DWARF_REGISTER 110
 # elif defined(__ppc__)
----------------
Don't hardcode a number here; add a define `_LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC64` further above like the other architectures


================
Comment at: src/Registers.hpp:1128
+  void        jumpto();
+  static int  lastDwarfRegNum() { return 108; }
+
----------------
... and use `_LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC64` here instead of a hardcoded number


================
Comment at: src/libunwind.cpp:84
 #ifdef UNW_REMOTE
+//TODO: add powerpc64 support
 /// Create a cursor into a thread in another process.
----------------
Why this comment here? Remote unwinding is unimplemented in libunwind, and I don't see how a ppc64 specific comment is needed here?


https://reviews.llvm.org/D41386