[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 18 19:50:43 PST 2017


mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

The rest of this LGTM.



================
Comment at: test/std/numerics/numeric.ops/transform.reduce/transform_reduce_iter_iter_iter_init.pass.cpp:61
 
+inline MoveOnly operator+(const MoveOnly& lhs, const MoveOnly& rhs)
+{
----------------
BillyONeal wrote:
> Should these go in MoveOnly.h ?
I think so. While you're at it, you can remove the `friend` declaration in `MoveOnly` - that's a remnant.


Repository:
  rL LLVM

https://reviews.llvm.org/D41372





More information about the cfe-commits mailing list