[PATCH] D40560: [analyzer] WIP: Get construction into `operator new` running in simple cases.

[Aleksei Sidorin via Phabricator via cfe-commits]

a.sidorin added a comment.

Hi Artem. This patch looks OK, just stylish issues.



================
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112
+  // It means that we cannot handle construction into null or garbage pointers.
+  // Such cosntructors need to be handled by checkers to ensure that a warning
+  // is displayed to the user and that analysis doesn't explore such paths
----------------
constructors


================
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:474
+  StmtNodeBuilder CallBldr(DstPreCall, DstPostCall, *currBldrCtx);
+  for (auto I: DstPreCall)
+    defaultEvalCall(CallBldr, I, *Call);
----------------
Space after ':'? (Same below and upper)


================
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:522
+    symVal = peekCXXNewAllocatorValue(State);
+  State = popCXXNewAllocatorValue(State);
+
----------------
Should this be under 'if' as well?


https://reviews.llvm.org/D40560