[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

Aleksey Shlyapnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 18 07:47:12 PST 2017


alekseyshl accepted this revision.
alekseyshl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
                                     StringRef Sanitizer) {
+  // Solaris ld doesn't need this.  Inhibit use of non-existant
+  // --export-dynamic.
----------------
ro wrote:
> alekseyshl wrote:
> > Can you elaborate why Solaris ld does not need dynamic lists? How does it export sanitizer symbols then?
> Solaris ld simply defaults to --export-dynamic.
Can we say then that ld "defaults to --export-dynamic behavior" (as --export-dynamic does not exists there) instead of "doesn't need this"?


Repository:
  rC Clang

https://reviews.llvm.org/D40903





More information about the cfe-commits mailing list