[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

Rainer Orth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 18 06:27:28 PST 2017


ro added a comment.

In https://reviews.llvm.org/D41240#955391, @rsmith wrote:

> Mechanically, the code change looks fine, but I can't comment on whether this is a correct change for Solaris, or whether the type provided by `__float128` would use the right floating-point representation. You will also need to provide a test for this change.


The representation of __float128 is the same on all x86 targets AFAICT (that's certainly how this is done in GCC).

I've looked at the tests currently testing __float128 and except for one (to be enabled in a moment) already pass with this patch.


Repository:
  rC Clang

https://reviews.llvm.org/D41240





More information about the cfe-commits mailing list