[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:169
+  }
+private:
+  SmallVector<StringRef, 1> CheckNames;
----------------
Please separate with empty line.


================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:170
+private:
+  SmallVector<StringRef, 1> CheckNames;
+  size_t NolintIndex = 0;
----------------
Please include header for SmallVector.h.


================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339
     std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider)
     : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
+      Profile(nullptr),
----------------
Please use default members initialization for DiagEngine and Profile.


https://reviews.llvm.org/D41326