[PATCH] D36952: [libclang] Add support for checking abstractness of records

Johann Klähn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 14:48:26 PST 2017


jklaehn added a comment.

Thanks! However, compared to diff 126298 (https://reviews.llvm.org/differential/diff/126298/), there seems to be duplication in the committed change (maybe some artifacts due to rebasing/merging?). Should I submit a follow-up patch to fix this?



================
Comment at: cfe/trunk/bindings/python/clang/cindex.py:1488
+
+    def is_abstract_record(self):
+        """Returns True if the cursor refers to a C++ record declaration
----------------
duplicate


================
Comment at: cfe/trunk/bindings/python/clang/cindex.py:3420
+
+  ("clang_CXXRecord_isAbstract",
+   [Cursor],
----------------
duplicate


================
Comment at: cfe/trunk/bindings/python/tests/cindex/test_cursor.py:289
+
+    def test_is_abstract_record(self):
+        """Ensure Cursor.is_abstract_record works."""
----------------
duplicate


Repository:
  rL LLVM

https://reviews.llvm.org/D36952





More information about the cfe-commits mailing list