[PATCH] D40929: Unblock Swift Calling Convention Mangling on Windows

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 13:48:11 PST 2017


rnk added a comment.

@compnerd's suggestion is still a decent one: https://reviews.llvm.org/D31372

Which, I think is just adding something wacky like `@swiftcc at __Swift@@` which would demangle as `__Swift::swiftcc` if the demangler expected an NNS there. Of course, it doesn't, so it won't demangle, but at least you can overload between cdecl and swiftcc then.



================
Comment at: lib/AST/MicrosoftMangle.cpp:2133
+      llvm::errs() << "Unsupported CC for mangling: " << CC << ".\n";
     case CC_Win64:
     case CC_X86_64SysV:
----------------
smeenai wrote:
> You still need the default label, right?
Surely we can emit a real custom diagnostic, similar to CodeGenModule::ErrorUnsupported.


Repository:
  rC Clang

https://reviews.llvm.org/D40929





More information about the cfe-commits mailing list