[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333-9335
+  "multiversion function would have identical mangling to a previous "
+  "definition.  Duplicate declarations must have identical target attribute "
+  "values">;
----------------
erichkeane wrote:
> aaron.ballman wrote:
> > Diagnostics are not complete sentences, so this should be reworded to be even less grammatically correct. ;-)
> I tried again, hopefully this one is better? :)  Let me know if my grammar is still too good...
You've achieved sufficiently incorrect grammar. ;-)


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333
+def err_multiversion_duplicate : Error<
+  "multiversion function duplicate declarations require identical target "
+  "attributes">;
----------------
instead of duplicate, do you mean redeclarations? Or do you mean overloaded declarations? Both?


https://reviews.llvm.org/D40819