[PATCH] D40488: [clangd] Implemented tracing using Context

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/Trace.cpp:123
+  // Clone the context, so that the original Context can be moved.
+  this->Ctx.emplace(Ctx.clone());
+
----------------
This is a little unfortunate. Oh, well.


================
Comment at: clangd/Trace.h:42
+/// set up before calling any clangd-specific functions.
+class TracingSession {
+public:
----------------
hmm, `trace::TracingSession` seems redundant? Up to you


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40488