[PATCH] D41217: [Concepts] Concept Specialization Expressions

changyu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 13 21:46:01 PST 2017


changyu added inline comments.


================
Comment at: lib/AST/ExprCXX.cpp:1481
+    if (E.isInvalid() || Trap.hasErrorOccurred()) {
+        // C++2a [temp.constr.atomic]p1
+        //   ...If substitution results in an invalid type or expression, the
----------------
You have four spaces of indenting here.


================
Comment at: lib/Parse/ParseExpr.cpp:225
+  if (Res.isUsable() && !Actions.CheckConstraintExpression(Res.get())) {
+      return ExprError();
+  }
----------------
Indenting.


Repository:
  rC Clang

https://reviews.llvm.org/D41217





More information about the cfe-commits mailing list