[PATCH] D41118: [clangd] Emit ranges for clangd diagnostics, and fix off-by-one positions

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 13 01:44:11 PST 2017


hokein added inline comments.


================
Comment at: test/clangd/diagnostics.test:10
 
 {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///foo.c","languageId":"c","version":1,"text":"void main() {}"}}}
 #      CHECK:  "method": "textDocument/publishDiagnostics",
----------------
Maybe the current tests are enough. Do we want to add a test where the diagnostic location is at the end of the line?

```
f()
// ^ missing ";"
f();
```


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41118





More information about the cfe-commits mailing list