[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

Casey Carter via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 9 09:22:53 PST 2017


CaseyCarter added a comment.

In https://reviews.llvm.org/D41048#950424, @lebedev.ri wrote:

> Test?


Four of the existing variant tests fail without this change (Using the clang-6 dailies from apt.llvm.org and -std=c++2a):

Failing Tests (4):

    libc++ :: std/utilities/variant/variant.get/get_if_type.pass.cpp
    libc++ :: std/utilities/variant/variant.get/get_type.pass.cpp
    libc++ :: std/utilities/variant/variant.get/holds_alternative.pass.cpp
    libc++ :: std/utilities/variant/variant.variant/variant.mod/emplace_type_init_list_args.pass.cpp
  
  Expected Passes    : 36
  Unexpected Failures: 4

I think that's plenty of test coverage.


https://reviews.llvm.org/D41048





More information about the cfe-commits mailing list