[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 8 09:17:27 PST 2017


smeenai added a comment.

The other runtime projects had the stripped installation targets added manually because they officially support being built completely standalone (i.e. without any LLVM components), so we can't rely on LLVM's CMake there. That's really unfortunate IMO, since it leads to a bunch of duplication, but it is what it is.

libunwind doesn't support building completely standalone AFAIK, so I think assuming trunk libunwind will be paired with trunk LLVM is pretty reasonable in general. It's easy enough to not break your use case here, however, so I went ahead and did so in r320163.


Repository:
  rL LLVM

https://reviews.llvm.org/D40685





More information about the cfe-commits mailing list