[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

LGTM, but I'd like the old `IdentifierTable` constructor to be removed if there are no callers left.



================
Comment at: include/clang/Basic/IdentifierTable.h:473-476
   /// \brief Create the identifier table, populating it with info about the
   /// language keywords for the language specified by \p LangOpts.
   IdentifierTable(const LangOptions &LangOpts,
+                  IdentifierInfoLookup *externalLookup = nullptr);
----------------
Can this constructor be removed?


https://reviews.llvm.org/D35181