[PATCH] D40948: Switch Clang's default C++ language target to C++14

Tim Northover via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 7 12:49:44 PST 2017


t.p.northover added inline comments.


================
Comment at: clang/test/SemaCXX/new-array-size-conv.cpp:1
-// RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s
+// RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=gnu++98 %s
 // RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=c++98 %s
----------------
probinson wrote:
> I think the intent here was "whatever the current default is" and not specifically gnu++98, because the next line explicitly specifies c++98.  So, unless this test fails miserably for C++14 (which I wouldn't expect) I think it should be adapted to whatever gets reported for that dialect.
The original commit of this file (r107229 from Doug Gregor) called out the fact that what's being tested is a GNU and C++0x extension.

I think that implies that the 3 run lines really *should* test gnu++98, c++98 and c++11.


Repository:
  rC Clang

https://reviews.llvm.org/D40948





More information about the cfe-commits mailing list