r319950 - [clang] Use PRIVATE in target_link_libraries

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 6 12:05:42 PST 2017


Author: smeenai
Date: Wed Dec  6 12:05:42 2017
New Revision: 319950

URL: http://llvm.org/viewvc/llvm-project?rev=319950&view=rev
Log:
[clang] Use PRIVATE in target_link_libraries

I'd missed this one in r319840 because I hadn't been configuring with an
order file before.

Modified:
    cfe/trunk/tools/driver/CMakeLists.txt

Modified: cfe/trunk/tools/driver/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/CMakeLists.txt?rev=319950&r1=319949&r2=319950&view=diff
==============================================================================
--- cfe/trunk/tools/driver/CMakeLists.txt (original)
+++ cfe/trunk/tools/driver/CMakeLists.txt Wed Dec  6 12:05:42 2017
@@ -123,7 +123,7 @@ if(CLANG_ORDER_FILE AND (LD64_EXECUTABLE
   if("${ORDER_FILE}" STREQUAL "\n")
     set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${CLANG_ORDER_FILE})
   elseif(LINKER_ORDER_FILE_WORKS)
-    target_link_libraries(clang ${LINKER_ORDER_FILE_OPTION})
+    target_link_libraries(clang PRIVATE ${LINKER_ORDER_FILE_OPTION})
     set_target_properties(clang PROPERTIES LINK_DEPENDS ${CLANG_ORDER_FILE})
   endif()
 endif()




More information about the cfe-commits mailing list