[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 6 11:07:32 PST 2017

ABataev added inline comments.

Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110
+            PrivateAddr.getPointer(),
+            SharedAddresses[N].first.getPointer()->getType());
+    llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);
Hahnfeld wrote:
> ABataev wrote:
> > Better to use `SharedAddresses[N].first.getAddress().getType()`
> Ok, was copied from below call to `castToBase()`. Should I adjust it there as well?
Yes, please

  rC Clang


More information about the cfe-commits mailing list