[PATCH] D39027: [docs][refactor] Add a new tutorial that talks about how one can implement refactoring actions
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 6 07:20:48 PST 2017
klimek added inline comments.
================
Comment at: docs/RefactoringActionTutorial.rst:7
+
+ This tutorial talks about a work-in-progress library in Clang.
+ Some of the described features might not be available yet in trunk, but should
----------------
hokein wrote:
> I'm a bit concerned about this. If we check in this doc before all features are implemented, it probably confuses users.
>
I'm not too concerned about this. The code is already there, so I believe more docs are better :)
================
Comment at: docs/RefactoringActionTutorial.rst:41-42
+ int computeArrayOffset(int x, int y) {
+ if (x >= 0) {
+ if (y >= 0) {
+ return x * 4 + y;
----------------
This looks like an example that's a better fit for clang-tidy?
Perhaps a good example would be replacing all int x, int y parameters to an const Point& parameter or something like that?
Repository:
rL LLVM
https://reviews.llvm.org/D39027
More information about the cfe-commits
mailing list